Skip to content

Commit 3fd76ab

Browse files
author
Till Brehm
committed
Merge branch '6637-zone-import-external-ns' into 'develop'
DNS import, add external NS as default, #6637 Closes #6637 See merge request ispconfig/ispconfig3!1845
2 parents 19055e6 + e626a14 commit 3fd76ab

File tree

4 files changed

+29
-1
lines changed

4 files changed

+29
-1
lines changed

interface/web/admin/form/system_config.tform.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,18 @@
487487
'value' => '',
488488
'name' => 'default_slave_dnsserver'
489489
),
490+
'dns_external_slave_fqdn' => array (
491+
'datatype' => 'VARCHAR',
492+
'formtype' => 'TEXT',
493+
'filters' => array(
494+
0 => array( 'event' => 'SAVE',
495+
'type' => 'STRIPTAGS'),
496+
1 => array( 'event' => 'SAVE',
497+
'type' => 'STRIPNL')
498+
),
499+
'default' => '',
500+
'value' => ''
501+
),
490502
'dns_show_zoneexport' => array (
491503
'datatype' => 'VARCHAR',
492504
'formtype' => 'CHECKBOX',

interface/web/admin/lib/lang/en_system_config.lng

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,5 @@ $wb['show_aps_menu_note_url_txt'] = 'Click here for more information.';
109109
$wb['dns_show_zoneexport_txt'] = 'Show zone export.';
110110
$wb['le_caa_autocreate_options_txt'] = 'Enable automatic creation of CAA record on issuing LE';
111111
$wb['show_delete_on_forms_txt'] = 'Show delete button on edit forms';
112+
$wb['dns_external_slave_server_txt'] = 'External DNS servers (comma separated)';
112113
?>

interface/web/admin/templates/system_config_dns_edit.htm

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,13 @@ <h1><tmpl_var name="list_head_txt"></h1>
1212
</select></div>
1313
</div>
1414

15+
<div class="form-group">
16+
<label class="col-sm-3 control-label">{tmpl_var name=dns_external_slave_server_txt'}</label>
17+
<div class="col-sm-9">
18+
<input type="text" name="dns_external_slave_fqdn" id="dns_external_slave_fqdn" value="{tmpl_var name='dns_external_slave_fqdn'}" size="" maxlength="" class="form-control" />
19+
</div>
20+
</div>
21+
1522
<div class="form-group">
1623
<label class="col-sm-3 control-label">{tmpl_var name=dns_show_zoneexport_txt'}</label>
1724
<div class="col-sm-9">

interface/web/dns/dns_import.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@
6464
$sys_groupid = $_SESSION["s"]["user"]["default_group"];
6565
}
6666
$domain = (isset($_POST['domain'])&&!empty($_POST['domain']))?$_POST['domain']:NULL;
67+
$settings = $app->getconf->get_global_config('dns');
68+
$external_slave_servers = $settings['dns_external_slave_fqdn'];
6769

6870
// get the correct server_id
6971
if (isset($_POST['server_id'])) {
@@ -73,7 +75,6 @@
7375
$server_id = $app->functions->intval($_POST['server_id_value']);
7476
$post_server_id = true;
7577
} else {
76-
$settings = $app->getconf->get_global_config('dns');
7778
$server_id = $app->functions->intval($settings['default_dnsserver']);
7879
$post_server_id = false;
7980
}
@@ -263,6 +264,13 @@ function fqdn_name( $owner, $origin ) {
263264
$servers[$i]['server_name'] .= ".";
264265
}
265266
}
267+
if (!empty($external_slave_servers)) {
268+
$external_servers = preg_split('/[\s,]+/', $external_slave_servers);
269+
foreach($external_servers as $e) {
270+
$servers[]['server_name'] = rtrim($e, '.') . '.';
271+
}
272+
}
273+
266274
$lines = file($_FILES['file']['tmp_name']);
267275

268276
// Remove empty lines, comments, whitespace, tabs, etc.

0 commit comments

Comments
 (0)