Extra error when No mail address available to sent an OTP code to

helmo · helmo · commit 3ddebfe99470 · 2023-02-01T17:00:06.000+01:00
diff --git a/interface/web/login/otp.php b/interface/web/login/otp.php
@@ -169,10 +169,13 @@ function finish_2fa_success($msg = '') {
 				if (!empty($clientuser['email'])) {
 					$email_to = $clientuser['email'];
 				}
-				else {
+				elseif(!empty($mail_config['admin_mail'])) {
 					// Admin users are not related to a client, thus use the globally configured email address.
 					$email_to = $mail_config['admin_mail'];
 				}
+				else {
+					$app->error('No mail address available to sent an OTP code to.', 'index.php');
+				}
 			}
 
 			$app->ispcmail->setSender($mail_config['admin_mail'], $mail_config['admin_name']);

Original file line number	Diff line number	Diff line change
`@@ -169,10 +169,13 @@ function finish_2fa_success($msg = '') {`
`169`	`169`	`if (!empty($clientuser['email'])) {`
`170`	`170`	`$email_to = $clientuser['email'];`
`171`	`171`	`}`
`172`		`- else {`
	`172`	`+ elseif(!empty($mail_config['admin_mail'])) {`
`173`	`173`	`// Admin users are not related to a client, thus use the globally configured email address.`
`174`	`174`	`$email_to = $mail_config['admin_mail'];`
`175`	`175`	`}`
	`176`	`+ else {`
	`177`	`+ $app->error('No mail address available to sent an OTP code to.', 'index.php');`
	`178`	`+ }`
`176`	`179`	`}`
`177`	`180`
`178`	`181`	`$app->ispcmail->setSender($mail_config['admin_mail'], $mail_config['admin_name']);`