Merge branch 'stable-3.1' into 'stable-3.1'

Marius Burkard · Marius Burkard · commit 39f51a4cc5fc · 2017-09-15T09:10:02.000+02:00
restrict permissions for db-dump during prepareDBDump

See merge request !643
diff --git a/install/lib/update.lib.php b/install/lib/update.lib.php
@@ -59,6 +59,8 @@ function prepareDBDump() {
 
 		system("mysqldump -h ".escapeshellarg($conf['mysql']['host'])." -u ".escapeshellarg($conf['mysql']['admin_user'])." -c -t --add-drop-table --create-options --quick --result-file=existing_db.sql ".$conf['mysql']['database']);
 	}
+	chmod('existing_db.sql', 0400);
+	chown('existing_db.sql', 'root');
 
 	/*
 	 * If we have a server with nothing in it except VE's then the database of thie server is empty.

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,8 @@ function prepareDBDump() {`
`59`	`59`
`60`	`60`	`system("mysqldump -h ".escapeshellarg($conf['mysql']['host'])." -u ".escapeshellarg($conf['mysql']['admin_user'])." -c -t --add-drop-table --create-options --quick --result-file=existing_db.sql ".$conf['mysql']['database']);`
`61`	`61`	`}`
	`62`	`+ chmod('existing_db.sql', 0400);`
	`63`	`+ chown('existing_db.sql', 'root');`
`62`	`64`
`63`	`65`	`/*`
`64`	`66`	`* If we have a server with nothing in it except VE's then the database of thie server is empty.`