Fix Error in scheduled jobs due to PHP 8 incompatibility, #6682

Author: helmo

server/lib/classes/backup.inc.php

@@ -1497,9 +1497,9 @@ protected static function generateExcludeList($backup_excludes, $arg, $pre='', $
         foreach ($backup_excludes as $ex) {
             # pass through escapeshellarg if not already done
             if ( preg_match( "/^'.+'$/", $ex ) ) {
-                $excludes .= "${arg}${pre}${ex}${post} ";
+                $excludes .= "{$arg}{$pre}{$ex}{$post} ";
             } else {
-                $excludes .= "${arg}" . escapeshellarg("${pre}${ex}${post}") . " ";
+                $excludes .= "{$arg}" . escapeshellarg("{$pre}{$ex}{$post}") . " ";
             }
         }
 
@@ -1870,8 +1870,8 @@ protected static function make_database_backup($web_domain, $backup_job)
             //* Remove old backups
             self::backups_garbage_collection($server_id, 'mysql', $domain_id);
             $prefix_list = array(
-                        "db_${db_name}_",
-                        "manual-db_${db_name}_",
+                        "db_{$db_name}_",
+                        "manual-db_{$db_name}_",
                     );
             self::clearBackups($server_id, $domain_id, intval($rec['backup_copies']), $db_backup_dir, $prefix_list);
         }

server/lib/classes/cron.d/100-monitor_clamav_log.inc.php

@@ -94,6 +94,7 @@ public function onRunJob() {
 
 		/* Get the data of the log */
 		$data = $this->_tools->_getLogData($type);
+		if ($data == null) $data = "\n";
 
 		/* Get the data from the LAST log-Entry.
 		 * if there can be found:

server/lib/classes/cron.d/100-monitor_mail_queue.inc.php

@@ -82,6 +82,7 @@ public function onRunJob() {
 
 		/* Get the data from the mailq */
 		$data['output'] = shell_exec('mailq');
+		if ($data['output'] == null) $data['output'] = "";
 
 		/*
 		 *  The last line has more informations

server/lib/classes/cron.d/100-monitor_system_update.inc.php

@@ -216,7 +216,7 @@ public function onRunJob() {
 
 		//* Ensure that output is encoded so that it does not break the serialize
 		//$res['data']['output'] = htmlentities($res['data']['output']);
-		$res['data']['output'] = htmlentities($res['data']['output'], ENT_QUOTES, 'UTF-8');
+		$res['data']['output'] = $res['data']['output'] ? htmlentities($res['data']['output'], ENT_QUOTES, 'UTF-8') : null;
 
 		/*
 		 * Insert the data into the database

server/lib/classes/db_mysql.inc.php

@@ -668,7 +668,7 @@ public function getDatabaseSize($database_name) {
 			$clientdb_user     = ($conf['db_user']) ? $conf['db_user'] : NULL;
 			$clientdb_password = ($conf['db_password']) ? $conf['db_password'] : NULL;
 			$clientdb_port     = ((int)$conf['db_port']) ? (int)$conf['db_port'] : NULL;
-			$clientdb_flags    = ($conf['db_flags'] !== NULL) ? $conf['db_flags'] : NULL;
+			$clientdb_flags    = (isset($conf['db_flags']) && $conf['db_flags'] !== NULL) ? $conf['db_flags'] : NULL;
 
 			require_once 'lib/mysql_clientdb.conf';