PHP 8 fixes

Author: tbrehm

interface/lib/classes/listform_actions.inc.php

@@ -189,7 +189,7 @@ public function prepareDataRow($rec)
 		//* substitute value for select fields
 		if(is_array($app->listform->listDef['item']) && count($app->listform->listDef['item']) > 0) {
 			foreach($app->listform->listDef['item'] as $field) {
-				if($rec['active'] == 'n') $rec['warn_inactive'] = 'y';
+				if(isset($rec['active']) && $rec['active'] == 'n') $rec['warn_inactive'] = 'y';
 				$key = $field['field'];
 				if(isset($field['formtype']) && $field['formtype'] == 'SELECT') {
 					if(strtolower($rec[$key]) == 'y' or strtolower($rec[$key]) == 'n') {

interface/lib/classes/tform_base.inc.php

@@ -1585,7 +1585,7 @@ function showForm() {
 
 		// Set form title
 		$form_hint = $this->lng($this->formDef["title"]);
-		if($this->formDef["description"] != '') $form_hint .= '<div class="pageForm_description">'.$this->lng($this->formDef["description"]).'</div>';
+		if(isset($this->formDef["description"]) && $this->formDef["description"] != '') $form_hint .= '<div class="pageForm_description">'.$this->lng($this->formDef["description"]).'</div>';
 		$app->tpl->setVar('form_hint', $form_hint);
 
 		// Set Wordbook for this form

interface/web/client/client_edit.php

@@ -119,7 +119,7 @@ function onSubmit() {
 			$this->oldTemplatesAssigned = array();
 		}
 
-		$this->_template_additional = explode('/', $this->dataRecord['template_additional']);
+		$this->_template_additional = (isset($this->dataRecord['template_additional']) && $this->dataRecord['template_additional'] != '')?explode('/', $this->dataRecord['template_additional']):array();
 		$this->dataRecord['template_additional'] = '';
 
 		parent::onSubmit();
@@ -169,7 +169,7 @@ function onShowEnd() {
 			// old style
 			$sql = "SELECT template_additional FROM client WHERE client_id = ?";
 			$result = $app->db->queryOneRecord($sql, $this->id);
-			$tplAdd = explode("/", $result['template_additional']);
+			$tplAdd = (isset($result['template_additional']) && $result['template_additional'] != '')?explode("/", $result['template_additional']):array();
 			$text = '';
 			foreach($tplAdd as $item){
 				if (trim($item) != ''){
@@ -293,7 +293,7 @@ function onAfterInsert() {
 			$app->auth->add_group_to_user($_SESSION['s']['user']['userid'], $groupid);
 			$app->db->query("UPDATE client SET parent_client_id = ? WHERE client_id = ?", $_SESSION['s']['user']['client_id'], $this->id);
 		} else {
-			if($this->dataRecord['parent_client_id'] > 0) {
+			if(isset($this->dataRecord['parent_client_id']) && $this->dataRecord['parent_client_id'] > 0) {
 				//* get userid of the reseller and add it to the group of the client
 				$tmp = $app->db->queryOneRecord("SELECT sys_user.userid FROM sys_user,sys_group WHERE sys_user.default_group = sys_group.groupid AND sys_group.client_id = ?", $this->dataRecord['parent_client_id']);
 				$app->auth->add_group_to_user($tmp['userid'], $groupid);
@@ -304,14 +304,14 @@ function onAfterInsert() {
 
 		//* Set the default servers
 		$tmp = $app->getconf->get_global_config('mail');
-		$default_mailserver = $app->functions->intval($tmp['default_mailserver']);
+		$default_mailserver = (isset($tmp['default_mailserver']))?$app->functions->intval($tmp['default_mailserver']):0;
 		if (!$default_mailserver) {
 			$tmp = $app->db->queryOneRecord('SELECT server_id FROM server WHERE mail_server = 1 AND mirror_server_id = 0 LIMIT 0,1');
 			$default_mailserver = $app->functions->intval($tmp['server_id']);
 		}
 		$tmp = $app->getconf->get_global_config('sites');
-		$default_webserver = $app->functions->intval($tmp['default_webserver']);
-		$default_dbserver = $app->functions->intval($tmp['default_dbserver']);
+		$default_webserver = (isset($tmp['default_webserver']))?$app->functions->intval($tmp['default_webserver']):0;
+		$default_dbserver = (isset($tmp['default_dbserver']))?$app->functions->intval($tmp['default_dbserver']):0;
 		if (!$default_webserver) {
 			$tmp = $app->db->queryOneRecord('SELECT server_id FROM server WHERE web_server = 1 AND mirror_server_id = 0 LIMIT 0,1');
 			$default_webserver = $app->functions->intval($tmp['server_id']);
@@ -321,7 +321,7 @@ function onAfterInsert() {
 			$default_dbserver = $app->functions->intval($tmp['server_id']);
 		}
 		$tmp = $app->getconf->get_global_config('dns');
-		$default_dnsserver = $app->functions->intval($tmp['default_dnsserver']);
+		$default_dnsserver = (isset($tmp['default_dnsserver']))?$app->functions->intval($tmp['default_dnsserver']):0;
 		if (!$default_dnsserver) {
 			$tmp = $app->db->queryOneRecord('SELECT server_id FROM server WHERE dns_server = 1 AND mirror_server_id = 0 LIMIT 0,1');
 			$default_dnsserver = $app->functions->intval($tmp['server_id']);

interface/web/mailuser/mail_user_autoresponder_edit.php

@@ -64,8 +64,8 @@ function onSubmit() {
 
 		//* if autoresponder checkbox not selected, do not save dates
 		if (!isset($_POST['autoresponder']) && array_key_exists('autoresponder_start_date', $_POST)) {
-			$this->dataRecord['autoresponder_start_date'] = array_map(function($item) { return 0;}), $this->dataRecord['autoresponder_start_date']);
-			$this->dataRecord['autoresponder_end_date'] = array_map(function($item) { return 0;}), $this->dataRecord['autoresponder_end_date']);
+			$this->dataRecord['autoresponder_start_date'] = array_map(function($item) { return 0;}, $this->dataRecord['autoresponder_start_date']);
+			$this->dataRecord['autoresponder_end_date'] = array_map(function($item) { return 0;}, $this->dataRecord['autoresponder_end_date']);
 
 			/* To be used when we go to PHP 7.x as min PHP version
 			$this->dataRecord['autoresponder_start_date'] = array_map( function ('$item') { 'return 0;' }, $this->dataRecord['autoresponder_start_date']);