Skip to content

Commit 31cc2ba

Browse files
author
Till Brehm
committed
Add support for --elliptic-curve secp256r1 in LE SSL certs with certbot.
1 parent 7c9b206 commit 31cc2ba

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

server/lib/classes/letsencrypt.inc.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,15 @@ public function get_certbot_command($domains) {
168168
$cert_selection_command = "--expand";
169169
}
170170

171-
$cmd = $letsencrypt . " certonly -n --text --agree-tos $cert_selection_command --authenticator webroot --server $acme_version --rsa-key-size 4096 --email webmaster@$primary_domain $webroot_args";
171+
if (version_compare($letsencrypt_version, '2.0', '>=')) {
172+
$app->log("LE version is " . $letsencrypt_version . ", so using --elliptic-curve secp256r1 instead of --rsa-key-size 4096", LOGLEVEL_DEBUG);
173+
$acme_key_size = "--elliptic-curve secp256r1";
174+
} else {
175+
$acme_key_size = "--rsa-key-size 4096";
176+
}
177+
178+
$cmd = $letsencrypt . " certonly -n --text --agree-tos $cert_selection_command --authenticator webroot --server $acme_version $acme_key_size --email webmaster@$primary_domain $webroot_args";
179+
172180

173181
return $cmd;
174182
}

0 commit comments

Comments
 (0)