Skip to content

Commit 2eb5d1b

Browse files
committed
- Cleaned up JavaScript code.
- Fix: IPv6 address must not be '*'.
1 parent 9576ebb commit 2eb5d1b

File tree

4 files changed

+28
-17
lines changed

4 files changed

+28
-17
lines changed

interface/web/admin/templates/server_config_web_edit.htm

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ <h2><tmpl_var name="list_head_txt"></h2>
6969
{tmpl_var name='check_apache_config'}
7070
</div>
7171
</div>
72-
<div class="ctrlHolder apache">
72+
<div class="ctrlHolder">
7373
<p class="label">{tmpl_var name='enable_sni_txt'}</p>
7474
<div class="multiField">
7575
{tmpl_var name='enable_sni'}
@@ -173,13 +173,13 @@ <h2><tmpl_var name="list_head_txt"></h2>
173173
<script language="JavaScript" type="text/javascript">
174174
var serverType = jQuery('#server_type').val();
175175
jQuery('#server_type').replaceWith('<label for="server_Type">'+serverType+'</label><input type="hidden" name="server_type" value="'+serverType+'">');
176-
adjustForm(serverType);
176+
adjustForm();
177177
jQuery('#server_type').change(function(){
178178
serverType = $(this).val();
179-
adjustForm(serverType);
179+
adjustForm();
180180
});
181181

182-
function adjustForm(serverType){
182+
function adjustForm(){
183183
if(serverType == "nginx"){
184184
jQuery('.nginx').show();
185185
jQuery('.apache').hide();

interface/web/sites/ajax_get_ip.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,11 @@
4343
$sql = "SELECT ip_address FROM server_ip WHERE ip_type = '$ip_type' AND server_id = $server_id";
4444
$ips = $app->db->queryAllRecords($sql);
4545
// $ip_select = "<option value=''></option>";
46-
$ip_select = "*";
46+
if($ip_type == 'IPv4'){
47+
$ip_select = "*";
48+
} else {
49+
$ip_select = "";
50+
}
4751
if(is_array($ips)) {
4852
foreach( $ips as $ip) {
4953
//$selected = ($ip["ip_address"] == $this->dataRecord["ip_address"])?'SELECTED':'';

interface/web/sites/templates/web_domain_advanced.htm

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,16 @@ <h2><tmpl_var name="list_head_txt"></h2>
5656
<script language="JavaScript" type="text/javascript">
5757
var webId = jQuery('input[name="id"]').val();
5858
var serverId;
59-
getServerId(webId);
60-
adjustForm(serverId);
59+
getServerId();
60+
adjustForm();
6161

62-
function getServerId(webId){
62+
function getServerId(){
6363
jQuery.getJSON('sites/ajax_get_json.php'+ '?' + Math.round(new Date().getTime()), {web_id : webId, type : "getserverid"}, function(data) {
6464
serverId = data.serverid;
6565
});
6666
}
6767

68-
function adjustForm(serverId){
68+
function adjustForm(){
6969
jQuery.getJSON('sites/ajax_get_json.php'+ '?' + Math.round(new Date().getTime()), {server_id : serverId, type : "getservertype"}, function(data) {
7070
if(data.servertype == "nginx"){
7171
jQuery('.nginx').show();

interface/web/sites/templates/web_domain_edit.htm

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,22 @@ <h2><tmpl_var name="list_head_txt"></h2>
1515
<input type="hidden" name="server_id" value="{tmpl_var name='server_id_value'}" />
1616
<tmpl_else>
1717
<label for="server_id">{tmpl_var name='server_id_txt'}</label>
18-
<select name="server_id" id="server_id" class="selectInput" onChange="reloadWebIP()">
18+
<select name="server_id" id="server_id" class="selectInput">
1919
{tmpl_var name='server_id'}
2020
</select>
2121
</tmpl_if>
2222
</div>
2323
<div class="ctrlHolder">
2424
<label for="client_group_id">{tmpl_var name='client_group_id_txt'}</label>
25-
<select name="client_group_id" id="client_group_id" class="selectInput" onChange="reloadWebIP()">
25+
<select name="client_group_id" id="client_group_id" class="selectInput">
2626
{tmpl_var name='client_group_id'}
2727
</select>
2828
</div>
2929
</tmpl_if>
3030
<tmpl_if name="is_reseller">
3131
<div class="ctrlHolder">
3232
<label for="client_group_id">{tmpl_var name='client_group_id_txt'}</label>
33-
<select name="client_group_id" id="client_group_id" class="selectInput" onChange="reloadWebIP()">
33+
<select name="client_group_id" id="client_group_id" class="selectInput">
3434
{tmpl_var name='client_group_id'}
3535
</select>
3636
</div>
@@ -133,19 +133,26 @@ <h2><tmpl_var name="list_head_txt"></h2>
133133
</div>
134134
<script language="JavaScript" type="text/javascript">
135135
var serverId;
136+
var clientGroupId = jQuery('#client_group_id').val();
136137
var serverIdDisabled = jQuery('#server_id_disabled').val();
137138
if(serverIdDisabled > 0){
138139
serverId = serverIdDisabled;
139140
} else {
140141
serverId = jQuery('#server_id').val();
141142
jQuery('#server_id').change(function(){
142143
serverId = $(this).val();
143-
adjustForm(serverId);
144+
adjustForm();
145+
reloadWebIP();
144146
});
145147
}
146-
adjustForm(serverId);
148+
adjustForm();
147149

148-
function adjustForm(serverId){
150+
jQuery('#client_group_id').change(function(){
151+
clientGroupId = $(this).val();
152+
reloadWebIP();
153+
});
154+
155+
function adjustForm(){
149156
jQuery.getJSON('sites/ajax_get_json.php'+ '?' + Math.round(new Date().getTime()), {server_id : serverId, type : "getservertype"}, function(data) {
150157
if(data.servertype == "nginx"){
151158
var selected = jQuery('#php').val();
@@ -166,8 +173,8 @@ <h2><tmpl_var name="list_head_txt"></h2>
166173
}
167174

168175
function reloadWebIP() {
169-
loadOptionInto('ip_address','sites/ajax_get_ip.php?ip_type=IPv4&server_id='+document.getElementById('server_id').value)&client_group_id='+document.getElementById('client_group_id').value);
170-
loadOptionInto('ipv6_address','sites/ajax_get_ip.php?ip_type=IPv6&server_id='+document.getElementById('server_id').value)&client_group_id='+document.getElementById('client_group_id').value);
176+
loadOptionInto('ip_address','sites/ajax_get_ip.php?ip_type=IPv4&server_id='+serverId+'&client_group_id='+clientGroupId);
177+
loadOptionInto('ipv6_address','sites/ajax_get_ip.php?ip_type=IPv6&server_id='+serverId+'&client_group_id='+clientGroupId);
171178
}
172179

173180
</script>

0 commit comments

Comments
 (0)