Skip to content

Commit 2add46b

Browse files
author
Pascal Dreissen
committed
Fix sorting bug e-mail backup stats
1 parent 24f9dd3 commit 2add46b

File tree

3 files changed

+36
-11
lines changed

3 files changed

+36
-11
lines changed

interface/web/mail/backup_stats.php

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,19 @@ public function prepareDataRow($rec)
2121
$app->uses('functions');
2222

2323
$rec = parent::prepareDataRow($rec);
24-
25-
$rec['active'] = "Yes";
26-
if ($rec['backup_interval'] === 'none') {
27-
$rec['active'] = "No";
24+
//var_dump($rec);
25+
$rec['active'] = $app->lng('yes_txt');
26+
if ($rec['backup_interval'] === 'none' || $rec['backup_interval'] === '') {
27+
$rec['backup_interval'] = strtolower($app->lng('None'));
28+
$rec['active'] = $app->lng('no_txt');
2829
$rec['backup_copies'] = 0;
2930
}
31+
$rec['interval_sort'] = $rec['type'] . $rec['backup_interval'];
3032
$recBackup = $app->db->queryOneRecord('SELECT COUNT(backup_id) AS backup_count FROM mail_backup WHERE mailuser_id = ?', $rec['mailuser_id']);
3133
$rec['backup_copies_exists'] = $recBackup['backup_count'];
3234
unset($recBackup);
3335
$recBackup = $app->db->queryOneRecord('SELECT SUM(filesize) AS backup_size FROM mail_backup WHERE mailuser_id = ?', $rec['mailuser_id']);
36+
$rec['backup_size_sort'] = $recBackup['backup_size'];
3437
$rec['backup_size'] = $app->functions->formatBytes($recBackup['backup_size']);
3538

3639
return $rec;

interface/web/mail/list/backup_stats.list.php

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
$liste["auth"] = "yes";
3030

3131
// mark columns for php sorting (no real mySQL columns)
32-
$liste["phpsort"] = array('used_sort', 'files');
32+
$liste["phpsort"] = array('active', 'interval_sort', 'backup_size_sort', 'backup_copies_exists');
3333

3434

3535
/*****************************************************
@@ -52,3 +52,14 @@
5252
'valuefield' => 'server_name'
5353
)
5454
);
55+
$liste["item"][] = array( 'field' => "email",
56+
'datatype' => "VARCHAR",
57+
'filters' => array( 0 => array( 'event' => 'SHOW',
58+
'type' => 'IDNTOUTF8')
59+
),
60+
'formtype' => "TEXT",
61+
'op' => "like",
62+
'prefix' => "%",
63+
'suffix' => "%",
64+
'width' => "",
65+
'value' => "");

interface/web/mail/templates/backup_stats_list.htm

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,24 @@ <h1><tmpl_var name="list_head_txt"></h1>
99
<table class="table">
1010
<thead class="dark form-group-sm">
1111
<tr>
12-
<th class="tiny-col" data-column="active"><tmpl_var name="active_txt"></th>
13-
<th data-column="domain"><tmpl_var name="domain_txt"></th>
14-
<th data-column="backup_server"><tmpl_var name="backup_server_txt"></th>
15-
<th data-column="backup_interval"><tmpl_var name="backup_interval_txt"></th>
16-
<th data-column="backup_count"><tmpl_var name="backup_count_txt"></th>
17-
<th data-column="backup_size"><tmpl_var name="backup_size_txt"></th>
12+
<th class="col-md-1" data-column="active"><tmpl_var name="active_txt"></th>
13+
<th class="col-md-3" data-column="email"><tmpl_var name="domain_txt"></th>
14+
<th class="col-md-3" data-column="server_id"><tmpl_var name="backup_server_txt"></th>
15+
<th class="col-md-2" data-column="interval_sort"><tmpl_var name="backup_interval_txt"></th>
16+
<th class="col-md-2" data-column="backup_copies_exists"><tmpl_var name="backup_count_txt"></th>
17+
<th class="col-md-2" data-column="backup_size_sort"><tmpl_var name="backup_size_txt"></th>
1818
</tr>
19+
<tr>
20+
<td class="active">&nbsp;</td>
21+
<td><input class="form-control" type="text" name="search_email" value="{tmpl_var name='search_email'}" /></td>
22+
<td class="backup_server">&nbsp;</td>
23+
<td class="backup_interval">&nbsp;</td>
24+
<td class="backup_count">&nbsp;</td>
25+
<td class="text-right">
26+
<button type="button" class="btn btn-default formbutton-default formbutton-narrow" name="Filter" id="Filter" value="{tmpl_var name="filter_txt"}" data-submit-form="pageForm" data-form-action="mail/backup_stats.php"><span class="icon icon-filter"></span></button>
27+
</td>
28+
</tr>
29+
1930
</thead>
2031
<tbody>
2132
<tmpl_loop name="records">

0 commit comments

Comments
 (0)