Fixed an issue with removing quotes in DNS records

tbrehm · tbrehm · commit 249f8b3b956f · 2025-04-18T20:43:54.000+02:00
diff --git a/interface/web/dns/dns_edit_base.php b/interface/web/dns/dns_edit_base.php
@@ -129,9 +129,9 @@ function onSubmit() {
 
 		if($this->checkDuplicate()) $app->tform->errorMessage .= $app->tform->lng("data_error_duplicate")."<br>";
 
-		// Remove accidental quotes around a record.
+		// Remove accidental quotes around a record
 		$matches = array();
-		if(preg_match('/^"(.*)"$/', $this->dataRecord["data"], $matches)) {
+		if(substr_count($this->dataRecord["data"], '"') == 2 && preg_match('/^"(.*)"$/', $this->dataRecord["data"], $matches)) {
 			$this->dataRecord["data"] = $matches[1];
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -129,9 +129,9 @@ function onSubmit() {`
`129`	`129`
`130`	`130`	`if($this->checkDuplicate()) $app->tform->errorMessage .= $app->tform->lng("data_error_duplicate")."<br>";`
`131`	`131`
`132`		`- // Remove accidental quotes around a record.`
	`132`	`+ // Remove accidental quotes around a record`
`133`	`133`	`$matches = array();`
`134`		`- if(preg_match('/^"(.*)"$/', $this->dataRecord["data"], $matches)) {`
	`134`	`+ if(substr_count($this->dataRecord["data"], '"') == 2 && preg_match('/^"(.*)"$/', $this->dataRecord["data"], $matches)) {`
`135`	`135`	`$this->dataRecord["data"] = $matches[1];`
`136`	`136`	`}`
`137`	`137`