Undefined variable $issued_successfully

HSorgYves · HSorgYves · commit 2482e0e3b279 · 2023-09-08T22:02:08.000+03:00
diff --git a/install/lib/installer_base.lib.php b/install/lib/installer_base.lib.php
@@ -3047,6 +3047,8 @@ public function make_ispconfig_ssl_cert() {
 			$crt_issuer = exec("openssl x509 -in ".escapeshellarg($ssl_crt_file)." -inform PEM -noout -issuer");
 		}
 
+		$issued_successfully = false;
+
 		if ((@file_exists($ssl_crt_file) && ($crt_subject == $crt_issuer)) || (!@is_dir($acme_cert_dir) || !@file_exists($check_acme_file) || !@file_exists($ssl_crt_file) || md5_file($check_acme_file) != md5_file($ssl_crt_file)) && $ip_address_match == true) {
 
 			// This script is needed earlier to check and open http port 80 or standalone might fail
@@ -3145,8 +3147,6 @@ public function make_ispconfig_ssl_cert() {
 				}
 			}
 
-			$issued_successfully = false;
-
 			// Backup existing ispserver ssl files
 			//
 			// We may find valid or broken symlinks or actual files here.

Original file line number	Diff line number	Diff line change
`@@ -3047,6 +3047,8 @@ public function make_ispconfig_ssl_cert() {`
`3047`	`3047`	`$crt_issuer = exec("openssl x509 -in ".escapeshellarg($ssl_crt_file)." -inform PEM -noout -issuer");`
`3048`	`3048`	`}`
`3049`	`3049`
	`3050`	`+ $issued_successfully = false;`
	`3051`	`+`
`3050`	`3052`	`if ((@file_exists($ssl_crt_file) && ($crt_subject == $crt_issuer)) \|\| (!@is_dir($acme_cert_dir) \|\| !@file_exists($check_acme_file) \|\| !@file_exists($ssl_crt_file) \|\| md5_file($check_acme_file) != md5_file($ssl_crt_file)) && $ip_address_match == true) {`
`3051`	`3053`
`3052`	`3054`	`// This script is needed earlier to check and open http port 80 or standalone might fail`
`@@ -3145,8 +3147,6 @@ public function make_ispconfig_ssl_cert() {`
`3145`	`3147`	`}`
`3146`	`3148`	`}`
`3147`	`3149`
`3148`		`- $issued_successfully = false;`
`3149`		`-`
`3150`	`3150`	`// Backup existing ispserver ssl files`
`3151`	`3151`	`//`
`3152`	`3152`	`// We may find valid or broken symlinks or actual files here.`