Bugfix: Spaces need to be deleted before cron save, because they are IGNORED on validation but lead to a non-functional cron.

mcramer · mcramer · commit 13bfc7cd321f · 2012-06-08T20:34:35.000Z
Storing minute / hour / etc. values like "1, 23, 26" (with spaces) is allowed in validation and interface but leads to a BLOCKED crontab file and to non-functional crons of the whole web user.
diff --git a/server/plugins-available/cron_plugin.inc.php b/server/plugins-available/cron_plugin.inc.php
@@ -198,7 +198,7 @@ function _write_crontab() {
 				if($job['run_month'] == '@reboot') {
 					$command = "@reboot";
 				} else {
-					$command = "{$job['run_min']}\t{$job['run_hour']}\t{$job['run_mday']}\t{$job['run_month']}\t{$job['run_wday']}";
+					$command = str_replace(" ", "", $job['run_min']) . "\t" . str_replace(" ", "", $job['run_hour']) . "\t" . str_replace(" ", "", $job['run_mday']) . "\t" . str_replace(" ", "", $job['run_month']) . "\t" . str_replace(" ", "", $job['run_wday']);
                 }
 				$command .= "\t{$this->parent_domain['system_user']}"; //* running as user
                 if($job['type'] == 'url') {

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ function _write_crontab() {`
`198`	`198`	`if($job['run_month'] == '@reboot') {`
`199`	`199`	`$command = "@reboot";`
`200`	`200`	`} else {`
`201`		`- $command = "{$job['run_min']}\t{$job['run_hour']}\t{$job['run_mday']}\t{$job['run_month']}\t{$job['run_wday']}";`
	`201`	`+ $command = str_replace(" ", "", $job['run_min']) . "\t" . str_replace(" ", "", $job['run_hour']) . "\t" . str_replace(" ", "", $job['run_mday']) . "\t" . str_replace(" ", "", $job['run_month']) . "\t" . str_replace(" ", "", $job['run_wday']);`
`202`	`202`	`}`
`203`	`203`	`$command .= "\t{$this->parent_domain['system_user']}"; //* running as user`
`204`	`204`	`if($job['type'] == 'url') {`