@@ -33,20 +33,20 @@ function prepareDBDump() {
3333 //** load the pre update sql script do perform modifications on the database before the database is dumped
3434 if (is_file (ISPC_INSTALL_ROOT ."/install/sql/pre_update.sql " )) {
3535 if ($ conf ['mysql ' ]['admin_password ' ] == '' ) {
36- caselog ("mysql --default-character-set= " .$ conf ['mysql ' ]['charset ' ]." -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' ' " . $ conf ['mysql ' ]['database ' ]. " ' < ' " .ISPC_INSTALL_ROOT ."/install/sql/pre_update.sql' &> /dev/null " , __FILE__ , __LINE__ , 'read in ispconfig3.sql ' , 'could not read in ispconfig3.sql ' );
36+ caselog ("mysql --default-character-set= " .escapeshellarg ( $ conf ['mysql ' ]['charset ' ]) ." -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " " . escapeshellarg ( $ conf ['mysql ' ]['database ' ]). " < ' " .ISPC_INSTALL_ROOT ."/install/sql/pre_update.sql' &> /dev/null " , __FILE__ , __LINE__ , 'read in ispconfig3.sql ' , 'could not read in ispconfig3.sql ' );
3737 } else {
38- caselog ("mysql --default-character-set= " .$ conf ['mysql ' ]['charset ' ]." -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' -p' " . $ conf ['mysql ' ]['admin_password ' ]. " ' ' " . $ conf ['mysql ' ]['database ' ]. " ' < ' " .ISPC_INSTALL_ROOT ."/install/sql/pre_update.sql' &> /dev/null " , __FILE__ , __LINE__ , 'read in ispconfig3.sql ' , 'could not read in ispconfig3.sql ' );
38+ caselog ("mysql --default-character-set= " .escapeshellarg ( $ conf ['mysql ' ]['charset ' ]) ." -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " -p " . escapeshellarg ( $ conf ['mysql ' ]['admin_password ' ]). " " . escapeshellarg ( $ conf ['mysql ' ]['database ' ]). " < ' " .ISPC_INSTALL_ROOT ."/install/sql/pre_update.sql' &> /dev/null " , __FILE__ , __LINE__ , 'read in ispconfig3.sql ' , 'could not read in ispconfig3.sql ' );
3939 }
4040 }
4141
4242 //** export the current database data
4343 if ( !empty ($ conf ["mysql " ]["admin_password " ]) ) {
4444
45- system ("mysqldump -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' -p' " . $ conf ['mysql ' ]['admin_password ' ]. " ' -c -t --add-drop-table --create-options --quick --result-file=existing_db.sql " .$ conf ['mysql ' ]['database ' ]);
45+ system ("mysqldump -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " -p " . escapeshellarg ( $ conf ['mysql ' ]['admin_password ' ]). " -c -t --add-drop-table --create-options --quick --result-file=existing_db.sql " .$ conf ['mysql ' ]['database ' ]);
4646 }
4747 else {
4848
49- system ("mysqldump -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' -c -t --add-drop-table --create-options --quick --result-file=existing_db.sql " .$ conf ['mysql ' ]['database ' ]);
49+ system ("mysqldump -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " -c -t --add-drop-table --create-options --quick --result-file=existing_db.sql " .$ conf ['mysql ' ]['database ' ]);
5050 }
5151
5252 /*
@@ -69,9 +69,9 @@ function prepareDBDump() {
6969 if ($ conf ['powerdns ' ]['installed ' ]) {
7070 //** export the current PowerDNS database data
7171 if ( !empty ($ conf ["mysql " ]["admin_password " ]) ) {
72- system ("mysqldump -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' -p' " . $ conf ['mysql ' ]['admin_password ' ]. " ' -c -t --add-drop-table --create-options --quick --result-file=existing_powerdns_db.sql " .$ conf ['powerdns ' ]['database ' ]);
72+ system ("mysqldump -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " -p " . escapeshellarg ( $ conf ['mysql ' ]['admin_password ' ]). " -c -t --add-drop-table --create-options --quick --result-file=existing_powerdns_db.sql " .$ conf ['powerdns ' ]['database ' ]);
7373 } else {
74- system ("mysqldump -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' -c -t --add-drop-table --create-options --quick --result-file=existing_powerdns_db.sql " .$ conf ['powerdns ' ]['database ' ]);
74+ system ("mysqldump -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " -c -t --add-drop-table --create-options --quick --result-file=existing_powerdns_db.sql " .$ conf ['powerdns ' ]['database ' ]);
7575 }
7676
7777 // create a backup copy of the PowerDNS database in the root folder
@@ -90,7 +90,7 @@ function checkDbHealth() {
9090 $ notok = array ();
9191
9292 echo "Checking ISPConfig database .. " ;
93- exec ("mysqlcheck -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' -p' " . $ conf ['mysql ' ]['admin_password ' ]. " ' -r " .$ conf ["mysql " ]["database " ], $ result );
93+ exec ("mysqlcheck -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " -p " . escapeshellarg ( $ conf ['mysql ' ]['admin_password ' ]). " -r " .escapeshellarg ( $ conf ["mysql " ]["database " ]) , $ result );
9494 for ( $ i =0 ; $ i <sizeof ($ result );$ i ++) {
9595 if ( substr ($ result [$ i ], -2 ) != "OK " ) {
9696 $ notok [] = $ result [$ i ];
@@ -155,9 +155,9 @@ function updateDbAndIni() {
155155 if (is_file ($ patch_filename )) {
156156 //* Load patch file into database
157157 if ( !empty ($ conf ["mysql " ]["admin_password " ]) ) {
158- system ("mysql --default-character-set= " .$ conf ['mysql ' ]['charset ' ]." --force -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' -p' " . $ conf ['mysql ' ]['admin_password ' ]. " ' " .$ conf ['mysql ' ]['database ' ]." < " .$ patch_filename );
158+ system ("mysql --default-character-set= " .escapeshellarg ( $ conf ['mysql ' ]['charset ' ]) ." --force -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " -p " . escapeshellarg ( $ conf ['mysql ' ]['admin_password ' ]). " " .escapeshellarg ( $ conf ['mysql ' ]['database ' ]) ." < " .$ patch_filename );
159159 } else {
160- system ("mysql --default-character-set= " .$ conf ['mysql ' ]['charset ' ]." --force -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' " .$ conf ['mysql ' ]['database ' ]." < " .$ patch_filename );
160+ system ("mysql --default-character-set= " .escapeshellarg ( $ conf ['mysql ' ]['charset ' ]) ." --force -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " " .escapeshellarg ( $ conf ['mysql ' ]['database ' ]) ." < " .$ patch_filename );
161161 }
162162 swriteln ($ inst ->lng ('Loading SQL patch file ' ).': ' .$ patch_filename );
163163 $ current_db_version = $ next_db_version ;
@@ -193,9 +193,9 @@ function updateDbAndIni() {
193193
194194 //** load old data back into database
195195 if ( !empty ($ conf ["mysql " ]["admin_password " ]) ) {
196- system ("mysql --default-character-set= " .$ conf ['mysql ' ]['charset ' ]." --force -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' -p' " . $ conf ['mysql ' ]['admin_password ' ]. " ' " .$ conf ['mysql ' ]['database ' ]." < existing_db.sql " );
196+ system ("mysql --default-character-set= " .escapeshellarg ( $ conf ['mysql ' ]['charset ' ]) ." --force -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " -p " . escapeshellarg ( $ conf ['mysql ' ]['admin_password ' ]). " " .escapeshellarg ( $ conf ['mysql ' ]['database ' ]) ." < existing_db.sql " );
197197 } else {
198- system ("mysql --default-character-set= " .$ conf ['mysql ' ]['charset ' ]." --force -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' " .$ conf ['mysql ' ]['database ' ]." < existing_db.sql " );
198+ system ("mysql --default-character-set= " .escapeshellarg ( $ conf ['mysql ' ]['charset ' ]) ." --force -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " " .escapeshellarg ( $ conf ['mysql ' ]['database ' ]) ." < existing_db.sql " );
199199 }
200200
201201 //** Get the database version number based on the patchfile
@@ -228,9 +228,9 @@ function updateDbAndIni() {
228228
229229 //** load old data back into the PowerDNS database
230230 if ( !empty ($ conf ["mysql " ]["admin_password " ]) ) {
231- system ("mysql --default-character-set= " .$ conf ['mysql ' ]['charset ' ]." --force -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' -p' " . $ conf ['mysql ' ]['admin_password ' ]. " ' " .$ conf ['powerdns ' ]['database ' ]." < existing_powerdns_db.sql " );
231+ system ("mysql --default-character-set= " .escapeshellarg ( $ conf ['mysql ' ]['charset ' ]) ." --force -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " -p " . escapeshellarg ( $ conf ['mysql ' ]['admin_password ' ]). " " .escapeshellarg ( $ conf ['powerdns ' ]['database ' ]) ." < existing_powerdns_db.sql " );
232232 } else {
233- system ("mysql --default-character-set= " .$ conf ['mysql ' ]['charset ' ]." --force -h ' " . $ conf ['mysql ' ]['host ' ]. " ' -u ' " . $ conf ['mysql ' ]['admin_user ' ]. " ' " .$ conf ['powerdns ' ]['database ' ]." < existing_powerdns_db.sql " );
233+ system ("mysql --default-character-set= " .escapeshellarg ( $ conf ['mysql ' ]['charset ' ]) ." --force -h " . escapeshellarg ( $ conf ['mysql ' ]['host ' ]). " -u " . escapeshellarg ( $ conf ['mysql ' ]['admin_user ' ]). " " .escapeshellarg ( $ conf ['powerdns ' ]['database ' ]) ." < existing_powerdns_db.sql " );
234234 }
235235 }
236236 }
0 commit comments