Skip to content

Commit 001bac9

Browse files
author
Marius Burkard
committed
Merge branch 'remove-php-modes' into 'master'
Remove php modes Closes #4893 See merge request ispconfig/ispconfig3!840
2 parents ea9f8ef + 7349f55 commit 001bac9

24 files changed

+37
-510
lines changed

install/dist/conf/gentoo.conf.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,6 @@
7272
$conf['mysql']['master_ispconfig_user'] = '';
7373
$conf['mysql']['master_ispconfig_password'] = md5(uniqid(rand()));
7474

75-
//* SuPHP
76-
$conf['suphp']['config_file'] = '/etc/suphp.conf';
77-
7875
//* Apache
7976
$conf['apache']['installed'] = false; // will be detected automatically during installation
8077
$conf['apache']['user'] = 'apache';

install/dist/lib/fedora.lib.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -696,11 +696,6 @@ public function configure_apache()
696696
global $conf;
697697

698698
if($conf['apache']['installed'] == false) return;
699-
if(is_file('/etc/suphp.conf')) {
700-
//replaceLine('/etc/suphp.conf','php=php:/usr/bin','x-httpd-suphp=php:/usr/bin/php-cgi',0);
701-
replaceLine('/etc/suphp.conf', 'docroot=', 'docroot=/var/www', 0);
702-
replaceLine('/etc/suphp.conf', 'umask=0077', 'umask=0022', 0);
703-
}
704699

705700
//* Create the logging directory for the vhost logfiles
706701
exec('mkdir -p /var/log/ispconfig/httpd');

install/dist/lib/gentoo.lib.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -555,19 +555,6 @@ public function configure_apache()
555555
mkdir($conf['ispconfig_log_dir'].'/httpd', 0755, true);
556556
}
557557

558-
if (is_file($conf['suphp']['config_file']))
559-
{
560-
$content = rf($conf['suphp']['config_file']);
561-
562-
if (!preg_match('|^x-httpd-suphp=php:/usr/bin/php-cgi$|m', $content))
563-
{
564-
$content = preg_replace('/;Handler for php-scripts/', ";Handler for php-scripts\nx-httpd-suphp=php:/usr/bin/php-cgi", $content);
565-
$content = preg_replace('/;?umask=\d+/', 'umask=0022', $content);
566-
}
567-
568-
$this->write_config_file($conf['suphp']['config_file'], $content);
569-
}
570-
571558
//* Enable ISPConfig default vhost settings
572559
$default_vhost_path = $conf['apache']['vhost_conf_dir'].'/'.$conf['apache']['vhost_default'];
573560
if (is_file($default_vhost_path))

install/dist/lib/opensuse.lib.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -663,13 +663,6 @@ public function configure_apache()
663663
//* enable apache logio module
664664
exec('a2enmod logio');
665665

666-
//if(is_file('/etc/suphp.conf')) {
667-
replaceLine('/etc/suphp.conf', 'php=php', 'x-httpd-suphp="php:/srv/www/cgi-bin/php5"', 0, 0);
668-
replaceLine('/etc/suphp.conf', 'php="php', 'x-httpd-suphp="php:/srv/www/cgi-bin/php5"', 0, 0);
669-
replaceLine('/etc/suphp.conf', 'docroot=', 'docroot=/srv/www', 0, 0);
670-
replaceLine('/etc/suphp.conf', 'umask=0077', 'umask=0022', 0);
671-
//}
672-
673666
if(!file_exists('/srv/www/cgi-bin/php5') && file_exists('/srv/www/cgi-bin/php')) {
674667
symlink('/srv/www/cgi-bin/php', '/srv/www/cgi-bin/php5');
675668
}
@@ -1249,9 +1242,6 @@ public function install_ispconfig()
12491242
}
12501243

12511244
}
1252-
1253-
// Fix a setting in vhost master file for suse
1254-
replaceLine('/usr/local/ispconfig/server/conf/vhost.conf.master', "suPHP_UserGroup", " suPHP_UserGroup <tmpl_var name='system_user'> <tmpl_var name='system_group'>", 0);
12551245
}
12561246

12571247
if($conf['nginx']['installed'] == true && $this->install_ispconfig_interface == true){

install/lib/installer_base.lib.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1938,12 +1938,6 @@ public function configure_apache() {
19381938
//* Create the logging directory for the vhost logfiles
19391939
if(!@is_dir($conf['ispconfig_log_dir'].'/httpd')) mkdir($conf['ispconfig_log_dir'].'/httpd', 0755, true);
19401940

1941-
if(is_file('/etc/suphp/suphp.conf')) {
1942-
replaceLine('/etc/suphp/suphp.conf', 'php="php:/usr/bin', 'x-httpd-suphp="php:/usr/bin/php-cgi"', 0);
1943-
//replaceLine('/etc/suphp/suphp.conf','docroot=','docroot=/var/clients',0);
1944-
replaceLine('/etc/suphp/suphp.conf', 'umask=00', 'umask=0022', 0);
1945-
}
1946-
19471941
if(is_file('/etc/apache2/sites-enabled/000-default')) {
19481942
replaceLine('/etc/apache2/sites-available/000-default', 'NameVirtualHost *', 'NameVirtualHost *:80', 1, 0);
19491943
replaceLine('/etc/apache2/sites-available/000-default', '<VirtualHost *>', '<VirtualHost *:80>', 1, 0);

interface/lib/classes/remote.d/server.inc.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ public function server_get_php_versions($session_id, $server_id, $php)
269269
$web_config[$server_id] = $app->getconf->get_server_config($server_id, 'web');
270270
$server_type = !empty($web_config[$server_id]['server_type']) ? $web_config[$server_id]['server_type'] : 'apache';
271271

272-
if ($php === 'php-fpm' || ($php === 'hhvm' && $server_type === 'nginx')) {
272+
if ($php === 'php-fpm') {
273273
$php_records = $app->db->queryAllRecords("SELECT * FROM server_php WHERE php_fpm_init_script != '' AND php_fpm_ini_dir != '' AND php_fpm_pool_dir != '' AND server_id = ? AND (client_id = 0)", $server_id);
274274
foreach ($php_records as $php_record) {
275275
$php_version = $php_record['name'].':'.$php_record['php_fpm_init_script'].':'.$php_record['php_fpm_ini_dir'].':'.$php_record['php_fpm_pool_dir'];

interface/web/admin/form/server_config.tform.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1242,7 +1242,7 @@
12421242
'datatype' => 'VARCHAR',
12431243
'formtype' => 'SELECT',
12441244
'default' => 'fast-cgi',
1245-
'value' => array('no' => 'disabled_txt', 'fast-cgi' => 'Fast-CGI', 'cgi' => 'CGI', 'mod' => 'Mod-PHP', 'suphp' => 'SuPHP', 'php-fpm' => 'PHP-FPM', 'hhvm' => 'HHVM'),
1245+
'value' => array('no' => 'disabled_txt', 'fast-cgi' => 'Fast-CGI', 'mod' => 'Mod-PHP', 'php-fpm' => 'PHP-FPM'),
12461246
'searchable' => 2
12471247
),
12481248
'nginx_cgi_socket' => array(

interface/web/client/form/client.tform.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1100,7 +1100,7 @@
11001100
'default' => '',
11011101
'separator' => ',',
11021102
'valuelimit' => 'client:web_php_options',
1103-
'value' => array('no' => 'Disabled', 'fast-cgi' => 'Fast-CGI', 'cgi' => 'CGI', 'mod' => 'Mod-PHP', 'suphp' => 'SuPHP', 'php-fpm' => 'PHP-FPM', 'hhvm' => 'HHVM')
1103+
'value' => array('no' => 'Disabled', 'fast-cgi' => 'Fast-CGI', 'mod' => 'Mod-PHP', 'php-fpm' => 'PHP-FPM')
11041104
),
11051105
'limit_cgi' => array (
11061106
'datatype' => 'VARCHAR',

interface/web/client/form/client_template.tform.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,7 @@
508508
'default' => '',
509509
'separator' => ',',
510510
'valuelimit' => 'client:web_php_options',
511-
'value' => array('no' => 'Disabled', 'fast-cgi' => 'Fast-CGI', 'cgi' => 'CGI', 'mod' => 'Mod-PHP', 'suphp' => 'SuPHP', 'php-fpm' => 'PHP-FPM', 'hhvm' => 'HHVM')
511+
'value' => array('no' => 'Disabled', 'fast-cgi' => 'Fast-CGI', 'mod' => 'Mod-PHP', 'php-fpm' => 'PHP-FPM')
512512
),
513513
'limit_cgi' => array (
514514
'datatype' => 'VARCHAR',

interface/web/client/form/reseller.tform.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1097,7 +1097,7 @@
10971097
),
10981098
'default' => '',
10991099
'separator' => ',',
1100-
'value' => array('no' => 'Disabled', 'fast-cgi' => 'Fast-CGI', 'cgi' => 'CGI', 'mod' => 'Mod-PHP', 'suphp' => 'SuPHP', 'php-fpm' => 'PHP-FPM', 'hhvm' => 'HHVM')
1100+
'value' => array('no' => 'Disabled', 'fast-cgi' => 'Fast-CGI', 'mod' => 'Mod-PHP', 'php-fpm' => 'PHP-FPM')
11011101
),
11021102
'limit_cgi' => array (
11031103
'datatype' => 'VARCHAR',

0 commit comments

Comments
 (0)